Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MEB-8: Catch SMTP exception in the mail sending module #243

Merged
merged 1 commit into from Dec 20, 2016
Merged

MEB-8: Catch SMTP exception in the mail sending module #243

merged 1 commit into from Dec 20, 2016

Conversation

gentlecat
Copy link
Contributor

No description provided.

Copy link
Member

@mayhem mayhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this do anything beyond just logging the error? The proper fix for this bug would be to prevent the user from submitting a form with an invalid email address. Does this code now do this?

@gentlecat
Copy link
Contributor Author

Well, it can be difficult to determine what invalid is. We do have formatting restrictions in the form on the website, so users have to provide an email address that is formatted like one. This makes sure that page load doesn't fail even if

  • their mail server is unreachable
  • our SMTP server is down
  • mailbox that they specified doesn't exist

@mayhem
Copy link
Member

mayhem commented Dec 19, 2016

Ok. :shipit:

Copy link
Member

@mayhem mayhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@gentlecat gentlecat merged commit 776252a into metabrainz:master Dec 20, 2016
@gentlecat gentlecat deleted the meb-8 branch December 20, 2016 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants