add match with block method to string. Fixes incorrect usage in docs #3606
+16
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the docs for MatchData it mentions an example using a block:
This example doesn't work in master as it throws
'String#match' is not expected to be invoked with a block, but a block was given
. This PR adds this block method in.One thing I do have a question about is in the docs it says
md.string
, but running the code like that will throw aundefined method 'string' for Nil
compile-time error. Addingnot_nil!
makes it work, but it feels weird to always have to add that in. Should this block just yieldmatch.not_nil!
? or should I also add in an update to the docs to show that usage?