wireguard: remove dependency on ip-up.target #20825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was deprecated and removed from all modules in the tree by NixOS#18319. The wireguard module PR (NixOS#17933) was still in the review at the time and the deprecated usage managed to slip inside.
|
@lbonn, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ericsagnes to be a potential reviewer. |
|
Looks good to me. |
|
Makes sense. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the wireguard service is not launched on startup.
The
ip-up.targetwas deprecated and removed from all modules in the tree by #18319.The wireguard module PR (#17933) was still in the review at the time and
the deprecated usage managed to slip inside.
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)