Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable_applet not working #633

Closed
sbourdeauducq opened this issue Nov 30, 2016 · 9 comments
Closed

disable_applet not working #633

sbourdeauducq opened this issue Nov 30, 2016 · 9 comments

Comments

@sbourdeauducq
Copy link
Member

(From #630)
@r-srinivas Please a print into the dashboard (here: https://github.com/m-labs/artiq/blob/master/artiq/dashboard/applets_ccb.py#L190) to check that it correctly receives the applet deletion request.

@sbourdeauducq
Copy link
Member Author

Or better, dump all calls to ccb_notify, so you can see the applet creation request as well which confirms you have modified the file correctly.

@r-srinivas
Copy link

r-srinivas commented Nov 30, 2016

I'm using artiq 3.0.dev py_252+git5b7e068 so it should have the fix for #629, and indeed it can create new groups now.

Adding print(service) to ccb_notify, on the dashboard I see,

INFO:dashboard:artiq.dashboard.experiments:Submitted 'repo:test/CreateCodeApplet
', RID is 20146
create_applet
QWindowsWindow::setGeometryDp: Unable to set geometry 200x130+0+0 on QWindow/''.
 Resulting geometry:  5x13+480+340 (frame: 0, 0, 0, 0, custom margin: 0, 0, 0, 0
, minimum size: 0x0, maximum size: 16777215x16777215).
QWindowsWindow::setGeometryDp: Unable to set geometry 200x130+0+0 on QWindow/''.
 Resulting geometry:  5x13+480+340 (frame: 0, 0, 0, 0, custom margin: 0, 0, 0, 0
, minimum size: 0x0, maximum size: 16777215x16777215).
QWindowsWindow::setGeometryDp: Unable to set geometry 200x130+0+0 on QWindow/''.
 Resulting geometry:  5x13+480+340 (frame: 0, 0, 0, 0, custom margin: 0, 0, 0, 0
, minimum size: 0x0, maximum size: 16777215x16777215).
QWindowsWindow::setGeometryDp: Unable to set geometry 200x130+0+0 on QWindow/''.
 Resulting geometry:  5x13+480+340 (frame: 0, 0, 0, 0, custom margin: 0, 0, 0, 0
, minimum size: 0x0, maximum size: 16777215x16777215).
disable_applet

So it looks like it's getting the command. Just to clarify, create_applet doesn't enable the applet. While the code_applet.py is running, I check it to see the countdown. Then at the end it should disable it and the applet should disappear, right? I'm wondering if the errors in between affect the disabling?

On the virtual machine (3.0.dev+252.g5b7e068),

INFO:dashboard:artiq.dashboard.experiments:Submitted 'repo:CreateCodeApplet', RID is 32
create_applet
QXcbConnection: XCB error: 8 (BadMatch), sequence: 2855, resource id: 69206020, major code: 1 (CreateWindow), minor code: 0
QXcbConnection: XCB error: 3 (BadWindow), sequence: 2858, resource id: 65011783, major code: 18 (ChangeProperty), minor code: 0
disable_applet

Doesn't disable either.

@sbourdeauducq
Copy link
Member Author

Stupid question, does right click -> global/group CCB policy -> Create and enable applets fix the problem?

@sbourdeauducq
Copy link
Member Author

it should disable it and the applet should disappear, right?

Yes.

@r-srinivas
Copy link

Stupid question, does right click -> global/group CCB policy -> Create and enable applets fix the problem?

Looks like that works, plus the #630 error message. Modifying the global CCB policy doesn't change the command entry for a particular group though.

Is having the create+enable on required for disabling to work how it's intended to work?

@sbourdeauducq
Copy link
Member Author

sbourdeauducq commented Dec 1, 2016

That's how it's intended to work. "Enable" could be changed to a term that means "mess with the user's windows", if we can find a good one.

@r-srinivas
Copy link

Okay, thanks. Maybe modify? User customisable?

@sbourdeauducq
Copy link
Member Author

It is user customizable already: ARTIQ is open source, you can patch your local installation :)
And this is a terrible idea. The purpose of a better name is to teach first-time users, asking them to customize it right away actually makes things worse.
I went for "enable/disable". "Modify" is too vague, as it can also mean that the applet list is being modified.

@r-srinivas
Copy link

r-srinivas commented Dec 1, 2016

I should clarify that I meant user customisable as a name, as in the user can customise how the applets appear. Enable/disable seems fine, though slightly confusing with also being able to enable/disable applets, but is to enable/disable ccb? Maybe something along the lines of experiment controlled as more descriptive?

Edit: I see you made it enable/disable applets. That seems sufficiently clear to me.

Sorry, something went wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants