Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

guile: apply patch fixing 00-repl-server.test stability (WIP) #20830

Merged
merged 1 commit into from
Dec 1, 2016
Merged

guile: apply patch fixing 00-repl-server.test stability (WIP) #20830

merged 1 commit into from
Dec 1, 2016
+8 −2

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Dec 1, 2016

Motivation for this change

This should fix the stability issues with the guile test. Testing!

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@grahamc
guile: apply patch fixing 00-repl-server.test stability

Verified

This commit was signed with the committer’s verified signature. The key has expired.
grahamc Graham Christensen
GPG key ID: ACA1C1D120C83D5C
Expired
Verified
Learn about vigilant mode
f1fd88f
@grahamc grahamc added 2.status: work-in-progress This PR isn't done 9.needs: port to stable A PR needs a backport to the stable release. labels Dec 1, 2016
@mention-bot
Copy link

@grahamc, thanks for your PR! By analyzing the history of the files in this pull request, we identified @pikajude, @lovek323 and @7c6f434c to be potential reviewers.

@grahamc
Copy link
Member Author

grahamc commented Dec 1, 2016

Builds nicely locally. Merging and backporting.

@grahamc grahamc removed the 2.status: work-in-progress This PR isn't done label Dec 1, 2016
@grahamc grahamc merged commit eeb1515 into NixOS:master Dec 1, 2016
@grahamc grahamc deleted the guile branch December 1, 2016 03:45
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grahamc @mention-bot @samueldr