Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thunderbird-bin: 45.5.0 -> 45.5.1 [Critical security fix] #20828

Merged
merged 1 commit into from
Dec 1, 2016

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Dec 1, 2016

Motivation for this change
  • Critical security fix.

https://www.mozilla.org/en-US/thunderbird/45.5.1/releasenotes/
https://www.mozilla.org/en-US/security/advisories/mfsa2016-92/

See also #20827

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@mention-bot
Copy link

@taku0, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mimadrid to be a potential reviewer.

@grahamc
Copy link
Member

grahamc commented Dec 1, 2016

Can you also submit the patches for thunderbird and firefox (ie: not -bin.)

@grahamc grahamc merged commit 855b799 into NixOS:master Dec 1, 2016
@taku0
Copy link
Contributor Author

taku0 commented Dec 1, 2016

@grahamc I will try it on the next release. I don't have knowledge and time for building Firefox for now.

@grahamc
Copy link
Member

grahamc commented Dec 1, 2016

OK I'll get them, thank you!

@grahamc
Copy link
Member

grahamc commented Dec 1, 2016

@taku0 while I do those updates, can you check to see if 45.5 (the ESR version) has an update?

@taku0
Copy link
Contributor Author

taku0 commented Dec 1, 2016

OK. I'm building Firefox 45.5.1esr now.

@taku0 taku0 mentioned this pull request Dec 1, 2016
7 tasks
@taku0
Copy link
Contributor Author

taku0 commented Dec 1, 2016

I have made a PR for ESR #20841.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants