Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openblas: refactor and set TARGET always #21055

Merged
merged 1 commit into from Dec 11, 2016
Merged

openblas: refactor and set TARGET always #21055

merged 1 commit into from Dec 11, 2016

Conversation

ttuegel
Copy link
Member

@ttuegel ttuegel commented Dec 10, 2016

Motivation for this change

The expression had become crufty after adding several platforms.

Even though we use DYNAMIC_ARCH, we need to set TARGET to something generic to avoid impurities.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ttuegel ttuegel self-assigned this Dec 10, 2016
@mention-bot
Copy link

@ttuegel, thanks for your PR! By analyzing the history of the files in this pull request, we identified @adnelson, @FPtje and @veprbl to be potential reviewers.

@ttuegel ttuegel merged commit 99bc7f1 into NixOS:master Dec 11, 2016
@ttuegel ttuegel mentioned this pull request Dec 11, 2016
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ttuegel ttuegel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ttuegel @mention-bot