aptly: add bash completion #21046
aptly: add bash completion #21046
Conversation
| goPackagePath = "github.com/smira/aptly"; | ||
| goDeps = ./deps.nix; | ||
|
|
||
| nativeBuildInputs = [ makeWrapper ]; | ||
|
|
||
| postInstall = '' | ||
| rm $bin/bin/man | ||
| mkdir -p $out/etc/bash_completion.d | ||
| ln -s ${aptlyCompletionSrc}/aptly $out/etc/bash_completion.d |
There was a problem hiding this comment.
Can you change to $out/share/bash-completion/completions/ please as it's more common, also look: #21053 currently installing this package on nixos would not include bash completions, as for go packages only bin is installed by default, we need something like completions output, i'm also facing the same problem.
There was a problem hiding this comment.
Can you change to $out/share/bash-completion/completions/ please as it's more common
Sure, I will update my pull request
currently installing this package on nixos would not include bash completions
Are you sure about that? When I install the package on NixOS the completion is working.
| mkdir -p $out/etc/bash_completion.d | ||
| ln -s ${aptlyCompletionSrc}/aptly $out/etc/bash_completion.d | ||
| mkdir -p $out/share/bash-completion/completions | ||
| ln -s ${aptlyCompletionSrc}/aptly $out/share/bash-completion/completions |
There was a problem hiding this comment.
Based on discussion here: #21053 completions should go to bin output, so please change to $bin/share/bash-completion/completions/. I'm sorry for confusion.
There was a problem hiding this comment.
I'm sorry for confusion
No problem 😀
please change to $bin/share/bash-completion/completions/
I made the change you requested and I squashed all the commits into one.
montag451
force-pushed
the
aptly-completion
branch
from
d602891
to
b871a20
Compare
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)