Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2592 #2593

Merged
merged 1 commit into from Dec 11, 2016
Merged

Fixes #2592 #2593

merged 1 commit into from Dec 11, 2016

Conversation

felixfontein
Copy link
Contributor

Forgot one return...

@felixfontein
Copy link
Contributor Author

@Kwpolska: the failing tests are the baseline. I don't see what went wrong here, though; maybe some dependency changed which now generates a slightly different output? Also, the same failing baseline differences show up for #2594, which has completely different code changes.

@Kwpolska Kwpolska merged commit 5bd54e1 into master Dec 11, 2016
@Kwpolska
Copy link
Member

That’s a lxml update, I just rebuilt the baseline.

@Kwpolska Kwpolska deleted the fixing-2592 branch December 11, 2016 08:32
@Kwpolska
Copy link
Member

PS. small and obvious fixes do not need to be done through a pull request, you may commit to master directly.

@felixfontein
Copy link
Contributor Author

Nope, that doesn't work anymore. I tried that first, and I got an error message that a review is required when trying to push to master. So I had to convert it to a PR first.

@Kwpolska
Copy link
Member

Oh, that’s a side effect of requiring reviews and protecting branches. Which does not affect administrators, so I didn’t notice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants