Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wxmac: fix build with clang-3.8 #21048

Merged
merged 1 commit into from Dec 14, 2016
Merged

wxmac: fix build with clang-3.8 #21048

merged 1 commit into from Dec 14, 2016

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Dec 10, 2016

Motivation for this change

@copumpkin This should fix the erlang builds with clang-3.8

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@LnL7 LnL7 added 2.status: work-in-progress 6.topic: darwin Running or building packages on Darwin labels Dec 10, 2016
@mention-bot
Copy link

@LnL7, thanks for your PR! By analyzing the history of the files in this pull request, we identified @pikajude to be a potential reviewer.

@LnL7 LnL7 changed the title wxmac: fix build with wxmac: fix build with clang-3.8 Dec 10, 2016
@matthewbauer matthewbauer mentioned this pull request Dec 12, 2016
Closed
@copumpkin
Copy link
Member

Nice, thanks!

@copumpkin copumpkin merged commit d77db89 into NixOS:staging Dec 14, 2016
@LnL7 LnL7 deleted the darwin-wxmac branch December 14, 2016 23:07
@LnL7
Copy link
Member Author

LnL7 commented Dec 14, 2016

Another big one is darwin.libauto, but I got a little stuck with that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LnL7 @mention-bot @copumpkin