New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Truffle] Run irb instead of reading from stdin by default. #4376
Conversation
This is a really crazy set of failures for such a small change. |
Maybe
And it's just doing: some/ruby -e "exit 0" |
tryProcessArgumentsWithRubyopts(); | ||
if (getScriptFileName() == null && System.console() != null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably need to check for the case with -e
here.
Does it still work as expected if you pipe input to the process? cat mydata | jruby -ne '...' |
Yes - that's what the |
Ok I guess I was not aware one could tell the difference. If so I don't think anyone intentionally types Ruby without a pipe or redirection |
This is actually in response to user testing with real people doing that and then sitting there staring at it for ages waiting for it to do something. They tend to be non Ruby programmers just wanting to experiment with Ruby like they do with Python and Node.js. |
Ah I came from awk, Perl, and all the languages which do sit there. I agree that if you can know this case it seems like a good idea to enter a repl. It might be worth also creating an RFE on Ruby lang |
0f5ac1e
to
52682f1
Compare
This continually confuses non-Ruby users who just run
ruby
and expect to see something.I could be convinced to not commit this.