Remove all uses of assert in the codebase
#2590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `assert` statement can be disabled (`python -O`) and often does not explain what went wrong. This replaces all uses of `assert` with an `if` and a `ValueError`. Signed-off-by: Chris Warrick <kwpolska@gmail.com>
felixfontein
approved these changes
Dec 10, 2016
| @@ -66,7 +66,8 @@ def _do_classification(self, site): | |||
| for lang in site.config['TRANSLATIONS'].keys(): | |||
| # Extract classifications for this language | |||
| classifications[lang] = taxonomy.classify(post, lang) | |||
| assert taxonomy.more_than_one_classifications_per_post or len(classifications[lang]) <= 1 | |||
| if not taxonomy.more_than_one_classifications_per_post and len(classifications[lang]) > 1: | |||
| raise ValueError("Too many {0} classifications for post {1}".format(taxonomy.classification_name, post.source_path) | |||
There was a problem hiding this comment.
There's one ) missing at the end of the line.
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
assertstatement can be disabled (python -O) and often does notexplain what went wrong. This replaces all uses of
assertwith anifand a
ValueError.This needs a logic review, I had to invert conditions manually.
Signed-off-by: Chris Warrick kwpolska@gmail.com