-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
steam: added documentation to nixpkgs manual #21047
Conversation
Looks good to me, merging |
Thank you very much for this documentation! Several nitpicks (nothing major which prevents merging this):
|
|
Yes, it is the info that was on the wiki, it means that binaries cannot be patched to not depend on a FHS environment because they are checked, i can update the doc to make it clearer and add the java override. |
No problem; if you don't have enough time I can update the documentation by myself (I have been postponing it for far too long already). Maybe we want to just drop the section about running the games with |
Well, i have time today and i don't mind one way or the other, so as you prefer. |
I won't have any till the mid-week, so if you want to go forward please! ~_^ |
Ok, i'm on it. |
Is there any doc anywhere about the |
I didn't know |
@xvapx Nope, and that's the problem. Quick informal introduction: In my personal experience, it works way better when runtime is composed of native NixOS libraries (unlike Steam, which works way better with vanilla Runtime). You get it like this:
@vcunat PoE runs nicely with it ^_^. |
Ok, thanks a lot! |
Looking back, the only my mention of steam-run that I can find is the original pull request. I should be ashamed for not documenting that earlier D: |
Well, it was clear enough in the PR, but i have been unable to find it until you pointed me. I just finished adding it, will PR in a moment. |
I don't think expecting people to find your PRs drown long ago in history is a good documentation practice ~_^
I'll look at your PR shortly, thanks!
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
I used to have problems with direct usage of steam* stuff, due to my unusual mounting setup of |
Motivation for this change
Add documentation about steam to nixpkgs manual, according to issue #13237
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)