Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppVeyor: set MAVEN_OPTS=-Xmx3g #4345

Merged
merged 4 commits into from Dec 5, 2016
Merged

AppVeyor: set MAVEN_OPTS=-Xmx3g #4345

merged 4 commits into from Dec 5, 2016

Conversation

olleolleolle
Copy link
Member

@olleolleolle olleolleolle commented Nov 29, 2016

This fiddle-with-the-appveyor-build PR tries to get around the issue in AppVeyor that Maven options are handed in a way that generates warnings on Java 8.

Example of build with warnings: https://ci.appveyor.com/project/jnr/jruby/build/2880/job/shniu1cn7yluu99o#L1692

The changes are:

  • set JAVA_OPTS and MAVEN_OPTS as "global" environment variables (for all of the matrix participants)
  • invalidate cache of downloaded Maven artifacts when the pom.rb changes

See #4075.

@enebo
Copy link
Member

enebo commented Nov 29, 2016

@olleolleolle sure let's try it.

@olleolleolle
Copy link
Member Author

Are the m2 caches really working? Seems like a lot of downloading. (I'm not used to Maven work, so I may be way off.)

@olleolleolle
Copy link
Member Author

Seen a few other Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=2G; support was removed in 8.0 but they're perhaps connected to the JAVA_OPTS?

@enebo
Copy link
Member

enebo commented Nov 29, 2016

@olleolleolle our build does download lots of crap once a day so it might be that build firing on appveyor...or not?

@mprins
Copy link
Contributor

mprins commented Dec 1, 2016

Are the m2 caches really working? Seems like a lot of downloading. (I'm not used to Maven work, so I may be way off.)

the maven cache is emptied on AppVeyor when the pom file is updated:

cache:
  - C:\Users\appveyor\.m2\repository -> pom.xml

Note; AppVeyor lacks a way to purges the cache manually unlike Travis-CI

@mkristian
Copy link
Member

@mprins would it be possible to associate the cache with pom.rb - as the current pom.xml is obsolete and there were already question whether or not to get rid of it.

@mprins
Copy link
Contributor

mprins commented Dec 2, 2016

Just change that line in the appveyor.yml to point to pom.rb instead

@olleolleolle
Copy link
Member Author

What is the needed amount of RAM to run the test suite in AppVeyor?

@kares
Copy link
Member

kares commented Dec 5, 2016

yaaay - finally a 💚 ci :) ... @olleolleolle maybe do the OPTS similar to how its done on travis-ci
there's JAVA_OPTS (for the suite - starts low due spawn-ed sub rubies) https://github.com/jruby/jruby/blob/master/.travis.yml#L31 (and MAVEN_OPTS for mvn) - hopefully similar values will do on Windows.

(... but if its green already than this is better than the current setting -> can be tuned later)

@olleolleolle
Copy link
Member Author

olleolleolle commented Dec 5, 2016

@kares An issue that I suspect is: AppVeyor is not run on all pushes? I can only see it run on my first commit to this PR.

And, thank you for the values tips - I changed the YAML config for AppVeyor to that.

Ugh: https://github.com/jruby/jruby/blob/master/.travis.yml#L12-L13 Should I recreate that logic?

@kares
Copy link
Member

kares commented Dec 5, 2016

aaah, bumper - do not know much about AppVeyor setup ... guess @enebo will have to approve the merge.
wouldn't worry about the MAVEN_OPTS mangling much -> unless the Windows CI runs into some trouble ...

@mprins
Copy link
Contributor

mprins commented Dec 5, 2016

@olleolleolle that referenced logic in the travis.yml does some java 7 specific setup; but on Appveyor you're just testing with java 8, so no point in trying to emulate that.

@olleolleolle
Copy link
Member Author

@mprins For Java8 on AppVeyor, should I add -XX:MaxMetaspaceSize=200M -XX:CompressedClassSpaceSize=200M to the MAVEN_OPTS?

Also: Do I need to have the data from JAVA_OPTS also in the MAVEN_OPTS?

@enebo enebo merged commit d2c34de into jruby:master Dec 5, 2016
@enebo enebo added this to the Non-Release milestone Dec 5, 2016
@olleolleolle olleolleolle deleted the patch-1 branch December 5, 2016 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants