Skip to content

Backport firefox 50.0.1 #20792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 1, 2016
Merged

Backport firefox 50.0.1 #20792

merged 5 commits into from
Dec 1, 2016
+185 −185

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Nov 29, 2016

Motivation for this change

There are critical fixes in 50.0.1: https://www.mozilla.org/en-US/security/advisories/mfsa2016-91/

@edolstra reverted the update to 50.0 due to breaking video, but we pretty well need to ship this update. I'm hoping to get some testing on this, get it fixed, and released.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@mention-bot
Copy link

@grahamc, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ttuegel, @edolstra and @taku0 to be potential reviewers.

@grahamc grahamc added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Nov 29, 2016
@grahamc
Copy link
Member Author

grahamc commented Nov 29, 2016

(If all is quiet on this, I'll go ahead and merge it at in 7 hours)

@FRidh
Copy link
Member

FRidh commented Nov 29, 2016

@grahamc it would be nice if your revert revert commit would describe why it is again reverted.

@grahamc
Copy link
Member Author

grahamc commented Nov 29, 2016 via email

grahamc and others added 5 commits November 29, 2016 10:11
@grahamc
Revert "Revert "firefox: 49.0.2 -> 50.0""
c83bd77 
This reverts commit fc711b5.

Broken video playback is serious, but 50.0.1 includes important
security updates we want to release.
@grahamc
firefox: 50.0 -> 5.0.1 for CVE-2016-9078
bd39c43 
(cherry picked from commit b04e23b)
@taku0
firefox-bin: 49.0 -> 49.0.2
166fc3d
@taku0
firefox-bin: 49.0.2 -> 50.0 (NixOS#20434)
ff9eb69 
(cherry picked from commit 76b1413)
@taku0
firefox-bin: 50.0 -> 50.0.1
3bf46ba 
(cherry picked from commit 2d341ca)
@grahamc grahamc force-pushed the backport-firefox-50.0.1 branch from 1975437 to 3bf46ba Compare November 29, 2016 15:15
@grahamc
Copy link
Member Author

grahamc commented Nov 29, 2016

I amended the revert, @FRidh, to include a note about why.

@grahamc grahamc merged commit 81c5fd3 into NixOS:release-16.09 Dec 1, 2016
@grahamc grahamc deleted the backport-firefox-50.0.1 branch December 1, 2016 00:22
adrianpk added a commit to adrianpk/nixpkgs that referenced this pull request May 31, 2024
@adrianpk
Merge pull request NixOS#20792 from grahamc/backport-firefox-50.0.1
6ffa969 
Backport firefox 50.0.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@grahamc @mention-bot @FRidh @taku0