Allow Time::Span to be divided by Time::Span #3749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RX14 Nice! Would you mind adding a spec? |
RX14
force-pushed
the
feature/timespan-divide
branch
from
a5040fc to
9d64835
Compare
RX14
changed the title
|
Updated |
Sija
reviewed
Dec 21, 2016
| @@ -207,6 +207,14 @@ describe Time::Span do | |||
| # TODO check overflow | |||
| end | |||
|
|
|||
| it "divides by another Time::Span" do | |||
| ratio = 20.minutes / 15.seconds | |||
| ratio.should eq(80.0) | |||
There was a problem hiding this comment.
I think this is fine. Dividing a time unit by a time unit gives something that has no unit.
There was a problem hiding this comment.
It's 80.0 because there are exactly 80 15 second intervals in 20 minutes. Adding a unit wouldn't make sense at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dividing a time span by a time span gives a ratio. This is useful for example for working out the number of periods in a larger time (e.g.
time_span / 15.seconds).