neko: 2.0.0 -> 2.1.0 #21072
Merged
neko: 2.0.0 -> 2.1.0 #21072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@boronine, thanks for your PR! By analyzing the history of the files in this pull request, we identified @aszlig, @dezgeg and @MarcWeber to be potential reviewers. |
|
Looking into breakage. |
|
Looks like this is the culprit: HaxeFoundation/neko#131 Still can't reproduce the actual error :( |
|
Patched version passes tests! I'm guessing the error was a result of an interaction of the kernel with Neko's low-level ELF concatenation hackery. The patches swap in a more robust technique, and should become part of the next release. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The motivation was to add Darwin support to Neko. I bumped the version to 2.1.0 where there the build process has been improved and dependencies have been updated. The patch specified in the previous version of this build has been merged into 2.1.0.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)