Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google-chrome: add new dependency on libxcb #21083

Merged
merged 1 commit into from
Dec 12, 2016
Merged

google-chrome: add new dependency on libxcb #21083

merged 1 commit into from
Dec 12, 2016

Conversation

msteen
Copy link
Contributor

@msteen msteen commented Dec 11, 2016

Motivation for this change

Latest version of Google Chrome requires an additional library named libxcb.

Things done

I have version 54.0.2840.100 running.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@mention-bot
Copy link

@msteen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @the-kenny, @benley and @aszlig to be potential reviewers.

@joachifm
Copy link
Contributor

joachifm commented Dec 11, 2016

Already done in 374f833, it'd be better to backport/cherry-pick that instead.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
(cherry picked from commit 374f833)
@msteen
Copy link
Contributor Author

msteen commented Dec 11, 2016

I have cherry picked the mentioned commit, thanks for the feedback! I have done a force push, please let me know if is correct now.

@the-kenny the-kenny merged commit f69ffdd into NixOS:release-16.09 Dec 12, 2016
adrianpk added a commit to adrianpk/nixpkgs that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants