Move has_really_fast_connection() to Nix (deployment.hasFastConnection) #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deployment.hasFastConnection can now be set via Nix, as the default value provided by the backend can't always be suited for all networking configurations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #551 #513
I actually would decouple
nix-copy-closure --gzipand binary substitution, as they don't necessarily belong together.If you're deploying 100 nodes, you might not want gzip as it's a huge overhead on the host machine, compressing all data. But the binary substitution might still do a good job deploying from S3. So anything we do not to overload the deployment host helps.
cc @edolstra @rbvermaa