-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dir.glob returns doubles, if used with recursive directory matchers "**" #4353
Comments
@sumitmah well, we can't tell for sure until we do not have a test-case, right? :) |
@kares I can add test case, I was concerned about other scenarios? do we have tests for them? |
The PR seems logical. You can run other test cases by running spec/mspec/bin/mspec ci spec/ruby/core/dir or some tests somewhere in test/mri (probably test/mri/ruby/test_dir.rb). You can also add cases to spec/ruby or test/jruby (rather not add to test/mri) that mimic the above cases. |
Thanks! @headius I'll check the specs. |
…return uniq results
@sumitmah I do not want to land this right before 9.1.7.0 but we will merge afterwards. |
@enebo when is 9.1.7.0 release planned? |
…return uniq results
[#4353] Ignore consecutive DOUBLE_STAR in glob_helper.
should be resolved as #4428 got merged. |
Environment
Expected Behavior
Actual Behavior
The text was updated successfully, but these errors were encountered: