Item13897: A bit of improvement to stringify()

foswiki · Dec 1, 2016 · c888484 · c888484
1 parent e284891
commit c888484
Showing 1 changed file with 11 additions and 8 deletions.
diff --git a/core/lib/Foswiki/Exception.pm b/core/lib/Foswiki/Exception.pm
@@ -57,8 +57,6 @@ use Foswiki::Class;
 extends qw(Foswiki::Object);
 with 'Throwable';
 
-#use overload '""' => 'to_str';
-
 our $EXCEPTION_TRACE = 0;
 
 =begin TML
@@ -174,18 +172,23 @@ sub BUILD {
       if DEBUG && $EXCEPTION_TRACE;
 }
 
-sub stringify {
+sub stringifyPostfix {
     my $this = shift;
-
-    return $this->text
-      . (
+    return (
         DEBUG
         ? "\n" . $this->stacktrace
         : ' at ' . $this->file . ' line ' . $this->line
-      );
+    );
+}
+
+sub stringify {
+    my $this = shift;
+
+    return $this->text . $this->stringifyPostfix;
 }
 
 around to_str => sub {
+    my $orig = shift;
     my $this = shift;
 
     my $boundary = '-' x 60;
@@ -593,7 +596,7 @@ around stringify => sub {
         $res->print( $this->status . " "
               . $this->header . "\n\n"
               . $this->text
-              . ( DEBUG ? $this->stacktrace : '' ) );
+              . $this->stringifyPostfix );
     }
 
     return $orig->($this);