Skip to content

Commit

Permalink
Item14233: Omit the catch-all tasks from changelogs
Browse files Browse the repository at this point in the history
Uses perl experimental smartmatch.  No damage here but eventually perl
is going to change the implementation  5.26 maybe?
  • Loading branch information
gac410 committed Dec 2, 2016
1 parent 01ab684 commit efab1aa
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion core/tools/check_extensions.pl
Expand Up @@ -3,7 +3,6 @@
use strict;
use warnings;

# cruise back up the tree until we find lib and data subdirs
use Cwd;
use File::Spec;
use File::Find;
Expand All @@ -14,6 +13,9 @@
my $extension = shift;
my %items; # Hash to cache item # & descriptions.

# Tasks that are typically left open and not documented in release notes, eg. Documentation, Translation, etc.
my @omit = (qw(Item13883 Item13884 Item13504));

my $start = `git describe --tags --abbrev=0`;
unless ($start) {
help();
Expand Down Expand Up @@ -81,6 +83,9 @@ END
my $last = '';
foreach my $item ( sort @itemlist ) {
next if $item eq $last;

#SMELL: SmartMatch is experimental. But had to give it a try. Will be changed in upcoming perl.
next if $item ~~ @omit;
$last = $item;
my $taskinfo = get_task_info($item);
print "WARNING: Wrong state: $taskinfo\n"
Expand Down

0 comments on commit efab1aa

Please sign in to comment.