matrix-synapse service: add missing $
#20801
Closed
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As-is the generated configuration file will include the line literally.
|
You should rather push this to master and then |
|
That is not possible in this case since the master branch has had a major version bump since the 16.09 release. The version bump also involved a refactoring of the service which also fixed this issue. That is why the PR is directly against 16.09. |
|
Ah, sorry, I was looking at the history but didn't check the dates. Go ahead. 👍 |
fpletz
approved these changes
Nov 30, 2016
|
Thanks! Rebased into release-16.09 in 5f40d80. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix the configuration file generated for Matrix Synapse. As-is the generated configuration file will include the line literally.
This issue only affects the stable branch since the master branch fixed this as part of a larger refactoring.