Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby-openssl
base: 7308da1c5047
Choose a base ref
...
head repository: jruby/jruby-openssl
compare: b5bec3e62ba5
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on Nov 29, 2016

  1. [test] port over from MRI suite to reproduce #113 regression 

    (introduced in 0.9.18)
    @kares
    kares committed Nov 29, 2016
    Copy the full SHA
    c621fc1 View commit details
    Browse the repository at this point in the history

  2. Fix ClassCastException in X509Store.verify 

    This commit changes the logic of the `X509StoreContext.initialize`
method, to address some test failures that were showing up in
`test_x509store.rb`.  The failures would occur during calls to
the `verify` method of `X509Store`.

It seems that the failures were introduced by the addition of the
`X509Cert.toJava` method in ecc1a05 .
The `toJava` method seems to be implicitly called when iterating over
a RubyArray in Java code, and the implementation of that method
now returns a BC object rather than the expected JRuby `X509Cert`
object.

This commit changes the iteration to use the `.eltOk` method to access
the underlying objects w/o the implicit call to `toJava`.
    @kares
    Chris Price authored and kares committed Nov 29, 2016
    Copy the full SHA
    b5bec3e View commit details
    Browse the repository at this point in the history