torsocks update & improvements #20902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joachifm, thanks for your PR! By analyzing the history of the files in this pull request, we identified @thoughtpolice, @roconnor and @dezgeg to be potential reviewers. |
- Remove redundant preConfigure torsocks installs into $libdir/torsocks, so setting libdir=$out/lib doesn't really help. To put the shared objects into $out/lib we'd have to manually move them into $out and patch various files (the script itself expects $libdir/torsocks). - Use nativeBuildInputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will squash before merge, but this changes a few things so perhaps somebody cares/wants to comment, so I thought it prudent to PR first.
Tested with
(with tor running)