Unescaping HTML in WordPress tags and categories. #2578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Worked for me with Python 3.5 and code looks sane to me aswell. Thank you @felixfontein! |
|
Good to hear! I'd like @Kwpolska to also take a look, especially at the function in |
Kwpolska
reviewed
Dec 17, 2016
|
|
||
|
|
||
| # http://stackoverflow.com/a/2087433 | ||
| if sys.version_info[0] == 3 and sys.version_info[1] >= 4: |
There was a problem hiding this comment.
Breaks with Python 4.0.
I’d suggest:
try:
import html
html_unescape = html.unescape
except (AttributeError, ImportError):
try:
# the whole ordealOr even don’t use html.unescape and always define our own.
There was a problem hiding this comment.
Yeah, that sounds better. About defining my own: doesn't sound like a very appealing idea to me.
felixfontein
force-pushed
the
wordpress-import-unescape-tags
branch
from
e49fb3e
to
1f273f1
Compare
Kwpolska
approved these changes
Dec 17, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2557.
@okin: can you test this with your older export?