New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add xpra display-manager #20904
Add xpra display-manager #20904
Conversation
@offlinehacker, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @aszlig and @joachifm to be potential reviewers. |
5c2a2bb
to
b72f8cc
Compare
I have not managed, to get pulseaudio forwarding working. It shows among pulseaudio recording and playback devices on server and client, but when i start chromium, there's no sound. As this is not so critial for me, i will solve this problem another time. |
|
||
execCmd = '' | ||
${optionalString (cfg.pulseaudio) | ||
"export PULSE_COOKIE=/var/run/pulse/.config/pulse/cookie"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intended to be in sync with environment.variables.PULSE_COOKIE
set above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
I will be doing more testing in following days and add some more usefull options(encryption). For now it works fine with my vbox dev vms. |
@offlinehacker: Have you tested that this does not break simple Btw, what does the xpra module give beyond |
I think this variable should be added in user environment variables, as
this is runtime environment speciffic? or at least somehow make it optional.
…On Mon, Dec 5, 2016, 3:03 PM Bjørn Forsman ***@***.***> wrote:
@offlinehacker <https://github.com/offlinehacker>: Have you tested that
this does not break simple xpra shadow ssh:myserver? I have to ask,
because you are removing XPRA_LOG_DIR which I explicitly added in 6d48539
<6d48539>
to make xpra run.
Btw, what does the xpra module give beyond xpra shadow ...?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20904 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAjvS_I_IcjwtulSXNRhEb6Y0G_PyKzDks5rFBnAgaJpZM4LDtKh>
.
|
@bjornfor as opposed to xpra shadow, I don't want to run any other display manager/desktop besides xpra |
@offlinehacker I'm curious to know what you're using this for. |
@NodeGuy i'm using it instead of display manager, so i can connect on it with xpra client and have separated windows for each application in a secure manner, not whole new desktop manager. I'm running it in my vm-s. |
Cool, thanks. |
I'm merging this, as i'm using xpra as display manager for a long time without any issues. |
@offlinehacker: But you are breaking "xpra shadow ssh:myserver"...? |
@bjornfor but |
Motivation for this change
This pull request adds xpra as display-manager, which allows forwarding of x11 windows over ssh/tcp/sockets... While this pull request does not support full desktops, i don't need that in first place and support for that can be added later.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)