Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xpra display-manager #20904

Merged
merged 5 commits into from Mar 5, 2017
Merged

Conversation

offlinehacker
Copy link
Contributor

Motivation for this change

This pull request adds xpra as display-manager, which allows forwarding of x11 windows over ssh/tcp/sockets... While this pull request does not support full desktops, i don't need that in first place and support for that can be added later.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@offlinehacker, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @aszlig and @joachifm to be potential reviewers.

@offlinehacker
Copy link
Contributor Author

I have not managed, to get pulseaudio forwarding working. It shows among pulseaudio recording and playback devices on server and client, but when i start chromium, there's no sound. As this is not so critial for me, i will solve this problem another time.


execCmd = ''
${optionalString (cfg.pulseaudio)
"export PULSE_COOKIE=/var/run/pulse/.config/pulse/cookie"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intended to be in sync with environment.variables.PULSE_COOKIE set above?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@offlinehacker
Copy link
Contributor Author

I will be doing more testing in following days and add some more usefull options(encryption). For now it works fine with my vbox dev vms.

@bjornfor
Copy link
Contributor

bjornfor commented Dec 5, 2016

@offlinehacker: Have you tested that this does not break simple xpra shadow ssh:myserver? I have to ask, because you are removing XPRA_LOG_DIR which I explicitly added in 6d48539 to make xpra run.

Btw, what does the xpra module give beyond xpra shadow ...?

@offlinehacker
Copy link
Contributor Author

offlinehacker commented Dec 5, 2016 via email

@offlinehacker
Copy link
Contributor Author

@bjornfor as opposed to xpra shadow, I don't want to run any other display manager/desktop besides xpra

@NodeGuy
Copy link

NodeGuy commented Dec 22, 2016

@offlinehacker I'm curious to know what you're using this for.

@offlinehacker
Copy link
Contributor Author

@NodeGuy i'm using it instead of display manager, so i can connect on it with xpra client and have separated windows for each application in a secure manner, not whole new desktop manager. I'm running it in my vm-s.

@NodeGuy
Copy link

NodeGuy commented Jan 13, 2017

Cool, thanks.

@offlinehacker
Copy link
Contributor Author

I'm merging this, as i'm using xpra as display manager for a long time without any issues.

@offlinehacker offlinehacker merged commit f5d81ed into NixOS:master Mar 5, 2017
@bjornfor
Copy link
Contributor

bjornfor commented Mar 5, 2017

@offlinehacker: But you are breaking "xpra shadow ssh:myserver"...?

@offlinehacker
Copy link
Contributor Author

@bjornfor but XPRA_LOG_DIR should not be set in package, this is runtime variable that you can set in user profile or system wide with environment.variables. I will still check if I can make default point to home and override on xserver start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants