terminus-font-ttf: init at 4.40.1 #20743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Nov 27, 2016
| ''; | ||
| homepage = http://files.ax86.net/terminus-ttf; | ||
| license = licenses.ofl; | ||
| maintainers = [ "oka.sux@gmail.com" ]; |
There was a problem hiding this comment.
we usually prefer an entry in lib/maintainers.nix instead.
gsmnv
force-pushed
the
terminus-font-ttf
branch
from
e0fa117
to
215c4db
Compare
|
@Mic92 Fixed, thanks! |
Mic92
reviewed
Nov 27, 2016
| @@ -495,4 +495,5 @@ | |||
| zimbatm = "zimbatm <zimbatm@zimbatm.com>"; | |||
| zohl = "Al Zohali <zohl@fmap.me>"; | |||
| zoomulator = "Kim Simmons <zoomulator@gmail.com>"; | |||
| okasu = "Okasu <oka.sux@gmail.com>"; | |||
There was a problem hiding this comment.
Please maintain alphabetically ordering in this file.
gsmnv
force-pushed
the
terminus-font-ttf
branch
from
215c4db
to
de925e9
Compare
|
@Mic92 Fixed, thanks! |
|
Thanks @okasu, I'll just move it in all-packages.nix to be beside terminus_font. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Would be good to have TTF version of terminus font which is already included in nixpkgs,
because non TTF version isn't usable within Java/Browser/etc applications.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)