Skip to content

ruby: add 2.3.3 #20755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ruby: add 2.3.3 #20755

wants to merge 1 commit into from
+16 −2

Conversation

manveru
Copy link
Contributor

@manveru manveru commented Nov 27, 2016 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@mention-bot
Copy link

@manveru, thanks for your PR! By analyzing the history of the files in this pull request, we identified @pikajude, @zimbatm and @vrthra to be potential reviewers.

@NeQuissimus
Copy link
Member

Could we not have replaced 2.3.1 with 2.3.3?

@grahamc
Copy link
Member

grahamc commented Nov 28, 2016

Merged in bff2b98

@grahamc grahamc closed this Nov 28, 2016
@manveru manveru deleted the ruby-2-3-3 branch November 30, 2017 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@manveru @mention-bot @NeQuissimus @grahamc