Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blivet: Remove unneccesary patching #20686

Merged
merged 1 commit into from
Nov 24, 2016

Conversation

binarin
Copy link
Contributor

@binarin binarin commented Nov 24, 2016

Motivation for this change

Fixes NixOS/nixops#552

--cache argument is now mandatory for pvscan both from hetzner rescue
system and from nixpkgs.

With this patch I was able to do successful deploy to hetzner host.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Fixes NixOS/nixops#552

`--cache` argument is now mandatory for `pvscan` both from hetzner rescue
system and from nixpkgs.
@mention-bot
Copy link

@binarin, thanks for your PR! By analyzing the history of the files in this pull request, we identified @aszlig, @edolstra and @nckx to be potential reviewers.

@NeQuissimus NeQuissimus merged commit 290ca28 into NixOS:master Nov 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants