Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs: 7.1.0 -> 7.2.0 #20650

Closed
wants to merge 1 commit into from
Closed

nodejs: 7.1.0 -> 7.2.0 #20650

wants to merge 1 commit into from

Conversation

lo1tuma
Copy link
Member

@lo1tuma lo1tuma commented Nov 23, 2016 •
edited

Things done
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

nodejs 7.2.0 depends on libuv 1.10.1

nodejs release notes
libuv changelog

@mention-bot
Copy link

@lo1tuma, thanks for your PR! By analyzing the history of the files in this pull request, we identified @groxxda, @cko and @gilligan to be potential reviewers.

@grahamc
Copy link
Member

grahamc commented Nov 28, 2016

This doesn't seem to be compiling for me (can't find relevant logs.) Can you check in to it?

vcunat pushed a commit that referenced this pull request Nov 29, 2016
@lo1tuma @vcunat
libuv: 1.9.1 -> 1.10.1
0f7f0ce 
Taken from #20650.
@vcunat
Copy link
Member

vcunat commented Nov 29, 2016 •
edited

I picked your libuv commit.

@lo1tuma lo1tuma changed the title libuv: 1.9.1 -> 1.10.1 and nodejs: 7.1.0 -> 7.2.0 nodejs: 7.1.0 -> 7.2.0 Nov 29, 2016
@lo1tuma
Copy link
Member Author

lo1tuma commented Nov 29, 2016

@vcunat Thanks, I’ve rebased this branch.

@grahamc I’ve just tested it on nixos and and compiles without any problems for me. Can you provide any more details what exactly did not work?

@lo1tuma
Copy link
Member Author

lo1tuma commented Dec 7, 2016

Closing in favor of #20975.

@lo1tuma lo1tuma closed this Dec 7, 2016
@lo1tuma lo1tuma deleted the libuv-1.10.1-node-7.2.0 branch December 7, 2016 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lo1tuma @mention-bot @grahamc @vcunat @pSub