qemu: add curl to buildInputs #20648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bjornfor, thanks for your PR! By analyzing the history of the files in this pull request, we identified @globin, @matthewbauer and @fpletz to be potential reviewers. |
fpletz
approved these changes
Nov 23, 2016
|
A 0.4% increase!!! Impossible! faints |
bjornfor
force-pushed
the
qemu-with-curl
branch
from
9329e63
to
54ba215
Compare
|
@copumpkin: Yeah, I know, big stuff! ;-) I'll merge it... |
Enables support for accessing files over HTTP: qemu-system-x86_64 -drive media=cdrom,file=http://host/path.iso,readonly Increases the closures size from 445 to 447 MiB.
bjornfor
force-pushed
the
qemu-with-curl
branch
from
54ba215
to
bbe5f99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Enables support for accessing files over HTTP:
Increases the closures size from 445 to 447 MiB.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)