use 'request' properly

metacpan · Nov 23, 2016 · 4013e1c · 4013e1c
1 parent 902ade1
commit 4013e1c
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 12 deletions.
diff --git a/lib/MetaCPAN/Web/Model/API/Author.pm b/lib/MetaCPAN/Web/Model/API/Author.pm
@@ -30,27 +30,27 @@ sub get {
     return $self->request( '/author/' . uc( $author[0] ) )
         if ( @author == 1 );
 
-    return $self->request( '/author/by_id?id=' . join ',', @author );
+    return $self->request( '/author/by_id', undef, { id => \@author } );
 }
 
 sub search {
     my ( $self, $query, $from ) = @_;
     my $cv = $self->cv;
     $from ||= 0;
-    $self->request("/author/by_key?key=$query&from=$from&size=10")->cb(
+    $self->request( '/author/by_key', undef,
+        { key => $query, from => $from, size => 10 } )->cb(
         sub {
             my $results = shift->recv;
             $cv->send($results);
         }
-    );
+        );
     return $cv;
 }
 
 sub by_user {
     my ( $self, $users ) = @_;
-    return $self->request(
-        '/author/by_user?fields=user,pauseid&user=' . join ',',
-        @{$users} );
+    return $self->request( '/author/by_user', undef,
+        { fields => [qw<user pauseid>], user => $users } );
 }
 
 __PACKAGE__->meta->make_immutable;

diff --git a/lib/MetaCPAN/Web/Model/API/Favorite.pm b/lib/MetaCPAN/Web/Model/API/Favorite.pm
@@ -86,11 +86,14 @@ sub by_user {
     my ( $self, $users, $size ) = @_;
     my @users = is_arrayref $users ? @{$users} : $users;
     return $self->request(
-        sprintf "/favorite/by_user?fields=%s&sort=%s&size=%s&users=%s",
-        'date,author,distribution',
-        'distribution',
-        $size || 250,
-        ( join ',' => @users )
+        '/favorite/by_user',
+        undef,
+        {
+            fields => [qw<date author distribution>],
+            sort   => 'distribution',
+            size   => $size || 250,
+            user   => \@users,
+        }
     );
 }
 

diff --git a/lib/MetaCPAN/Web/Model/API/Release.pm b/lib/MetaCPAN/Web/Model/API/Release.pm
@@ -392,7 +392,7 @@ sub favorites {
 
 sub topuploaders {
     my ( $self, $range ) = @_;
-    $self->request('/author/top_uploaders?range=$range');
+    $self->request( '/author/top_uploaders', undef, { range => $range } );
 }
 
 __PACKAGE__->meta->make_immutable;