wireguard: 0.0.20161209 -> 0.0.20161218 #21277
Conversation
|
@Mic92, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ericsagnes, @fpletz and @womfoo to be potential reviewers. |
| { stdenv, fetchurl, libmnl, iproute, kernel ? null }: | ||
|
|
||
| # 0.0.20161216 introduced a non-backwards protocol change. | ||
| # this version is kept around to have a version compatible with nixos stable. |
There was a problem hiding this comment.
No. This is not okay. Do not keep this old version around. Stability with the wireguard snapshots has NEVER been guaranteed and there have been several warnings about it. It will be broken away. Absolutely do not merge this old version into Nix.
There was a problem hiding this comment.
I agree with this comment. Any reply, @Mic92?
There was a problem hiding this comment.
Sorry @Mic92, I see you didn't merge this. :)
There was a problem hiding this comment.
Judging by the fact that he closed the pull request, I believe this terrible idea is dead.
| @@ -11213,7 +11213,9 @@ in | |||
| virtualbox = pkgs.virtualboxHardened; | |||
| }; | |||
|
|
|||
| wireguard = callPackage ../os-specific/linux/wireguard { }; | |||
| # kept for backwards compatibility with nixos 16.03 | |||
| wireguard_0_0_20161209 = callPackage ../os-specific/linux/wireguard/0.0.20161209.nix { }; | |||
|
Hi -- upstream here. WireGuard has never had a guarantee about protocol stability between snapshots. At some point a 1.0 will be announced, and then things will be stable. Until then, WireGuard is experimental. This has been warned in several places. Keeping old versions around is dangerous. You must not keep around 20161209 around. Do not merge this pull request. |
|
delayed until #21145 is fixed. |
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)