Select anchor from location.hash on page load #3623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
force-pushed
the
docs-onload-anchor
branch
from
4d71e7d
to
c4fc7e5
Compare
|
Thanks!! Do you have any idea why hitting the "back" browser button doesn't work well? Since you fixed this issue maybe you understand why this happens. The steps to reproduce are:
|
|
@asterite For me the steps would be:
Honestly I don't know what's the real cause of this issue :/ Closest thing I've found related to the issue at hand would be this SO question: http://stackoverflow.com/questions/27046851/browser-back-button-does-not-work-for-anchor-links. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes scrolling to section given in URI hash (like in https://crystal-lang.org/api/0.20.0/Array.html#clear-instance-method). This works around bug which resets container scroll on page refresh.