Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: crystal-lang/crystal
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e84e2c4bcd42
Choose a base ref
...
head repository: crystal-lang/crystal
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: dd4c33e02991
Choose a head ref
  • 2 commits
  • 5 files changed
  • 1 contributor

Commits on Dec 2, 2016

  1. Fix typo

    Ary Borenszweig committed Dec 2, 2016
    Copy the full SHA
    24b6395 View commit details

  2. Compiler: be more permissive with initialize as macro methods 

    Right now an initialize that is a macro method fails to type-check
because the compiler can't prove that instance vars inside it
were initialized (because the macro will be expanded later)

This change makes the compiler initially ignore those methods,
and check that instance vars were proplery initialized later on.

This allows, for example, generating an initialize method
from a JSON pull parser by traversing a type's instance vars,
something that can't currently be done.
    Ary Borenszweig committed Dec 2, 2016
    Copy the full SHA
    dd4c33e View commit details
Loading