Update wording on root install #1143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenkozar
reviewed
Dec 2, 2016
| @@ -18,11 +18,11 @@ if [ -z "$USER" ]; then | |||
| fi | |||
|
|
|||
| if [ "$(id -u)" -eq 0 ]; then | |||
| printf '\e[1;31mwarning: installing Nix as root is not supported by this script!\e[0m\n' | |||
| printf '\e[1;31mwarning: although it has some users, installing Nix as root is not supported by this script. This install will continue, but we recommend aborting and installing as a user instead.\e[0m\n' | |||
There was a problem hiding this comment.
oh - I meant 'users' -- as in "there are some people who use this successfully"
|
Perhaps add info on how to overcome this? In fact, you have to execute only two commands to be able to install Nix as root https://github.com/elitak/nixos-infect/blob/master/nixos-infect#L158-L159 |
|
@danbst That's not completely true. For non-root users to be able to use Nix, you must have nix-daemon setup correctly. |
matthewbauer
reviewed
Dec 4, 2016
| fi | ||
|
|
||
| echo "performing a single-user installation of Nix..." >&2 |
There was a problem hiding this comment.
It's still single-user; it's just that single-user happens to be root.
This was referenced Sep 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the wording in the installer when it warns about installing as root.
Also: move the "installing as single-user" print inside the else-clause so that it's less misleading
This closes #1125