Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd: add slice support #21298

Merged
merged 1 commit into from
Dec 20, 2016
Merged

systemd: add slice support #21298

merged 1 commit into from
Dec 20, 2016

Conversation

dmmarkov
Copy link

@dmmarkov dmmarkov commented Dec 20, 2016

Motivation for this change

Last week I found that I can't create and use slices in nixpkgs. I need it to control resources for some groups of services in systemd. I add this code like like targets, services and etc.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@arch1tect0r, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @bluescreen303 and @rickynils to be potential reviewers.

@Mic92
Copy link
Member

Mic92 commented Dec 20, 2016

Thanks. Works for me.

@Mic92 Mic92 merged commit efd5508 into NixOS:master Dec 20, 2016
@dmmarkov dmmarkov deleted the add-slice-support branch August 20, 2018 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants