-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Truffle] Attempt at removing core from mx. #4371
Conversation
2b56607
to
906360c
Compare
if classic: | ||
main_class = "org.jruby.Main" | ||
else: | ||
main_class = "org.jruby.truffle.Main" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
classic will not launch anymore if the jar is not on the classpath, so probably this launcher should not support classic anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
@@ -143,21 +222,10 @@ def mavenLib(mavenDep, sha1, sourceSha1, license): | |||
"license": "EPL-1.0", | |||
}, | |||
|
|||
# Depends on jruby-core extracting jni libs in lib/jni | |||
"jruby-lib-jni": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the native *.so needed to be real files on the filesystem, is this not required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that was just classic. At least, everything seems to run without it. I know they aren't needed to be on the filesystem by JNI in the first place.
906360c
to
5d498ad
Compare
5d498ad
to
a04f66d
Compare
base = "https://search.maven.org/remotecontent?filepath=%s/%s/%s/%s-%s-%s" % args | ||
else: | ||
args = (groupId.replace('.', '/'), artifactId, version, artifactId, version) | ||
base = "https://search.maven.org/remotecontent?filepath=%s/%s/%s/%s-%s" % args |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a fair bit of duplication here, not sure how to fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
"112ff54474f1f04ccf1384c92e39fdc566f0bb5e", | ||
"BSD-new"), | ||
|
||
"JNR_UNIXSOCKET": mavenLib( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't use this project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh you're right. I'm sure we were. I think I even remember making commits to it to make it work for us.
No description provided.