[Truffle] Attempt at removing core from mx. #4371
Conversation
chrisseaton
force-pushed
the
truffle-mx-no-core
branch
from
2b56607
to
906360c
Compare
| if classic: | ||
| main_class = "org.jruby.Main" | ||
| else: | ||
| main_class = "org.jruby.truffle.Main" |
There was a problem hiding this comment.
classic will not launch anymore if the jar is not on the classpath, so probably this launcher should not support classic anymore.
| @@ -143,21 +222,10 @@ def mavenLib(mavenDep, sha1, sourceSha1, license): | |||
| "license": "EPL-1.0", | |||
| }, | |||
|
|
|||
| # Depends on jruby-core extracting jni libs in lib/jni | |||
| "jruby-lib-jni": { | |||
There was a problem hiding this comment.
I thought the native *.so needed to be real files on the filesystem, is this not required?
There was a problem hiding this comment.
I think that was just classic. At least, everything seems to run without it. I know they aren't needed to be on the filesystem by JNI in the first place.
chrisseaton
force-pushed
the
truffle-mx-no-core
branch
from
906360c
to
5d498ad
Compare
chrisseaton
force-pushed
the
truffle-mx-no-core
branch
from
5d498ad
to
a04f66d
Compare
| base = "https://search.maven.org/remotecontent?filepath=%s/%s/%s/%s-%s-%s" % args | ||
| else: | ||
| args = (groupId.replace('.', '/'), artifactId, version, artifactId, version) | ||
| base = "https://search.maven.org/remotecontent?filepath=%s/%s/%s/%s-%s" % args |
There was a problem hiding this comment.
There is a fair bit of duplication here, not sure how to fix it.
| "112ff54474f1f04ccf1384c92e39fdc566f0bb5e", | ||
| "BSD-new"), | ||
|
|
||
| "JNR_UNIXSOCKET": mavenLib( |
There was a problem hiding this comment.
We don't use this project.
There was a problem hiding this comment.
Huh you're right. I'm sure we were. I think I even remember making commits to it to make it work for us.
No description provided.