firefox-esr: 45.5.0 -> 45.5.1 #20841
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
The video situation is the same for me before this PR but it does work with non-ESR firefox. Perhaps some of the major updates were significant in this respect... |
vcunat
pushed a commit
that referenced
this pull request
Dec 1, 2016
(cherry picked from commit 36f980b)
adrianpk
added a commit
to adrianpk/nixpkgs
that referenced
this pull request
May 31, 2024
(cherry picked from commit 36f980b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
https://www.mozilla.org/en-US/security/advisories/mfsa2016-92/
See also #20827
See also #20828
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)It works except mp2t video playing.
I can play MP4, WebM, and Ogg videos with ESR (e.g. http://techslides.com/sample-webm-ogg-and-mp4-video-files-for-html5), but I cannot play videos on Twitter (e.g. https://twitter.com/search?q=%23PS4share%20&src=typd), which seems to be mp2t videos. I can play those videos with firefox-bin.