shadow: fix collision with coreutils (man groups.1.gz) #20804
Merged
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `groups.1.gz` collides with one from coreutils. The code to fix this was already present in expression, but wrongly assumes that share/man/man1 directory will be copied to `man` output after `installPhase`. It turned out, that man directory is set at configure step, so we should remove file from `man` output.
|
@danbst, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @rbvermaa and @wkennington to be potential reviewers. |
|
Works for me. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
groups.1.gzcollides with one from coreutils. The code to fix thiswas already present in expression, but wrongly assumes that share/man/man1
directory will be copied to
manoutput afterinstallPhase.It turned out, that man directory is set to
manoutput at configure step, so we shouldremove file from
manoutput.