Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes: 1.4.6 -> 1.5.1 #21125

Merged
merged 5 commits into from Jan 15, 2017
Merged

Conversation

moretea
Copy link
Contributor

@moretea moretea commented Dec 13, 2016

Motivation for this change

Updating k8s to 1.5.0 1.5.1, which supports the Container Runtime Interface.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

The tests fail at the moment, because the kube-apiserver has some ACL problem:

kubernetes# [   88.484428] kube-apiserver[785]: [192.482µs] [167.339µs] Conversion doneError from server (Forbidden): error when creating "/nix/store/yi7231sbjw2b15ywp9anfac7i2innlm6-redis-master-pod.json": pods "redis" is forbidden: service account default/default was not found, retry after the service account is created

@mention-bot
Copy link

@moretea, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ebzzry, @offlinehacker and @rushmorem to be potential reviewers.

@moretea moretea changed the title kubernetes: 1.4.6 -> 1.5.0 kubernetes: 1.4.6 -> 1.5.1 Dec 14, 2016
@moretea
Copy link
Contributor Author

moretea commented Dec 14, 2016

After updating this PR to 1.5.1, the k8s tests still fail.

@moretea
Copy link
Contributor Author

moretea commented Dec 14, 2016

One problem is that the generated docker image is not valid.

I'm getting the following error when the docker daemon starts:

[    9.708936] dockerd[1230]: time="2016-12-14T12:01:32.822686391Z" level=info msg="libcontainerd: new containerd process, pid: 1238"
[    9.805169] dockerd[1230]: time="2016-12-14T12:01:32.919309844Z" level=warning msg="devmapper: Usage of loopback devices is strongly discouraged for production use. Please use `--storage-opt dm.thinpooldev` or use `man docker` to refer to dm.thinpooldev section."
[    9.839039] dockerd[1230]: time="2016-12-14T12:01:32.953487093Z" level=warning msg="devmapper: Base device already exists and has filesystem xfs on it. User specified filesystem  will be ignored."
[    9.850956] dockerd[1230]: time="2016-12-14T12:01:32.965431349Z" level=info msg="[graphdriver] using prior storage driver \"devicemapper\""
[    9.917129] dockerd[1230]: time="2016-12-14T12:01:33.030317808Z" level=fatal msg="Error starting daemon: layer does not exist"

After deleting /var/lib/docker, I can successfully start docker.service again. /cc @offlinehacker @domenkozar

UPDATE: This was probably caused by an invalid state in the qcow2 image in /tmp/vm-state-kubernetes

@offlinehacker
Copy link
Contributor

offlinehacker commented Dec 14, 2016 via email

@moretea
Copy link
Contributor Author

moretea commented Dec 14, 2016

Apparently the VM state was tainted. After removing the /tmp/vm-state-kubernetes directory, that problem disappeared.

@moretea
Copy link
Contributor Author

moretea commented Dec 14, 2016

@offlinehacker I noticed that the cluster test is broken on master as well. I'll try to fix that.

@offlinehacker
Copy link
Contributor

@moretea finishing kubernetes tests and fixing any bugs would be very helpful.

@offlinehacker
Copy link
Contributor

This PR has merge conflicts, needs reading.

@moretea moretea force-pushed the update-k8s-to-1.5 branch 2 times, most recently from 265b624 to 0850b66 Compare December 18, 2016 14:13
@moretea
Copy link
Contributor Author

moretea commented Dec 21, 2016

@offlinehacker After rebasing it's getting OOM errors on my 16GB laptop, see https://gist.github.com/moretea/961bb2bac9bee39416c43a4204aebedc

@offlinehacker
Copy link
Contributor

@moretea you can disable docs generation(comment out) for now if that seems to be an issue

@moretea
Copy link
Contributor Author

moretea commented Jan 15, 2017

I found the problem and fixed it in a39ac20

Tested with nix-build nixos/tests/kubernetes.nix -A trivial

@offlinehacker if you're OK with these changes, I'll squash this to one commit.

@offlinehacker
Copy link
Contributor

@moretea thanks! this looks good, squash into one commit and i can merge this. @matejc is working on multy-node cluster using flannel, and this update might also help him with some bugs he has.

@Mic92
Copy link
Member

Mic92 commented Jan 15, 2017

@offlinehacker btw. you can squash commits also as a maintainer on merge.

@offlinehacker
Copy link
Contributor

@moretea actually you can probably squash only first 3 commits and leave the rest, at they make sense to be separated. @Mic92 thanks!

Disabled "mungedocs", which broke the build.
This appears to be a piece of development tooling to make sure that
the documentation is correct. We don't really care about that when we
a specific k8s version for NixOS.
Dig could not be found in the test cases. Adding it as a global package
fixes this.
@moretea
Copy link
Contributor Author

moretea commented Jan 15, 2017

@offlinehacker done.

@moretea
Copy link
Contributor Author

moretea commented Jan 15, 2017

@moretea thanks! this looks good, squash into one commit and i can merge this. @matejc is working on multy-node cluster using flannel, and this update might also help him with some bugs he has.

Is there a PR for this? I could not find it. I guess that a general mechanism for CNI should be the solution there. I'm willing to contribute to that.

@offlinehacker
Copy link
Contributor

@moretea well nixos module has support for CNI, issue is that @matejc was unable to make CNI flannel plugin work with flannel service, some routing/firewall issues, have to deploy corrosion setup to see their config

@offlinehacker offlinehacker merged commit e35212a into NixOS:master Jan 15, 2017
@moretea moretea deleted the update-k8s-to-1.5 branch January 15, 2017 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants