Patch/renderingbug #254
Merged
Patch/renderingbug #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EBI have moved their repo so I've updated that here also. Hopefully travis now builds okay. |
egonw
reviewed
Dec 14, 2016
| @@ -355,7 +355,7 @@ | |||
| <id>ebi-repo</id> | |||
| <name>EBI Maven Repository</name> | |||
| <url> | |||
| http://www.ebi.ac.uk/intact/maven/nexus/content/repositories/ebi-repo/ | |||
| http://www.ebi.ac.uk/~maven/m2repo | |||
There was a problem hiding this comment.
Ah, that change I had to do for PMR's AMI too :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug in the layout caused co-linear chains to be inverted. The existing code tried to point the direction away from the centre of the molecule, valid when the chain is kinked but not when co-linear. Here we now just return the vector. An artefact of this folding back on it's self caused a problem with the rendering make an SVG file that was 1.4 light years tall :-).
The huge SVG: here.