Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ecryptfs test: use TTY output to stabilize test #20876

Merged
merged 1 commit into from
Dec 3, 2016
Merged

ecryptfs test: use TTY output to stabilize test #20876

merged 1 commit into from
Dec 3, 2016

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Dec 3, 2016

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@grahamc, thanks for your PR! By analyzing the history of the files in this pull request, we identified @obadz to be a potential reviewer.

@grahamc
Copy link
Member Author

grahamc commented Dec 3, 2016

I've tested this before, but want to test again prior to merging.

@grahamc grahamc merged commit d41e141 into NixOS:master Dec 3, 2016
@grahamc grahamc deleted the ecryptfs branch December 3, 2016 15:03
@obadz
Copy link
Contributor

obadz commented Dec 3, 2016

Very nice!! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grahamc @mention-bot @obadz