Notebook shortcode #192
Notebook shortcode #192
Conversation
|
Pretty nifty! Please add this to README: Also, This should not leave any |
| @@ -52,8 +52,8 @@ def render_notebook(self, filename, site=None, data=None, lang=None, post=None): | |||
| export_html = HTMLExporter(config=c) | |||
| (notebook_raw, _) = export_html.from_filename(filename) | |||
|
|
|||
| # The raw HTML contains garbage (scripts and styles), we can’t leave it in | |||
| # The raw HTML contains garbage (scripts and styles). Extract only div id=notebook-container and children | |||
There was a problem hiding this comment.
id won’t be nice either, I’d prefer to avoid having duplicate id tags if someone uses multiple notebooks in a post. But it seems you can’t fix it any better.
There was a problem hiding this comment.
Seems like we could do something like the following to remove the ids (I'm not too familiar with lxml, so there might be a cleaner way iterate over the notebook elements).
notebook_el = notebook_html.xpath('//*[@id="notebook"]')[0]
notebook_el.attrib.pop('id')
notebook_container_el = notebook_html.xpath('//*[@id="notebook-container"]')[0]
notebook_container_el.attrib.pop('id')
notebook_code = lxml.html.tostring(notebook_el, encoding='unicode')
I did a quick pass over the ipython css and nikola doesn't do any selection by id, so this appears to work.
At any rate, the merged version also works (at least in my tests), despite not being valid HTML, so we can leave this for the future.
|
Thanks for contributing! 🎉 The plugin will be available for download after midnight UTC. |
This is a small shortcode to adapt existing notebooks into markup-based posts.