Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to pass IO to from_yaml #3662

Merged
merged 1 commit into from
Dec 12, 2016
Merged

Allow to pass IO to from_yaml #3662

merged 1 commit into from
Dec 12, 2016
+9 −4

Conversation

makenowjust
Copy link
Contributor

I don't know why from_yaml is restricted by String (Yesterday's implementation doesn't support IO?)

@asterite
Copy link
Member

Looks good, thanks! Probably a remanent of when we didn't support IO.

@asterite asterite merged commit a7135c8 into crystal-lang:master Dec 12, 2016
@asterite asterite added this to the 0.20.2 milestone Dec 12, 2016
@makenowjust makenowjust deleted the fix/from-yaml-allow-io branch December 12, 2016 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind:feature topic:stdlib
Projects
None yet
Milestone
0.20.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@makenowjust @asterite