New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of unicode quotes #1140
Conversation
I'll merge this quickly before it gets out of sync. Other PRs will get out of sync, but we can't really avoid that. |
This reverts commit f78126b. There really is no need for such a massive change...
Info/ping: reverted. (I personally don't have a strong opinion on this.) |
@vcunat I don't care either, but we need global guidelines. In #947, @domenkozar asked me to use ASCII quotes, which also made sense. This PR is just the generalization of the aforementioned comment. Do we want to
@edolstra: Does your commit message (hereafter) mean that there is need for any change ?
|
Ah, bummer. I don't even know how I'd enter a non-ASCII quote, aside from copy paste... So it would seem like a nice thing to get rid of them. (They don't look/feel significantly better, and they tend to trip up text selections in terminal emulators.) |
@edolstra any comment? |
(3) is really really painful, as each contirbutor has to change something she/he wasn't responsible for. That's why I went for 2. |
These unicode quotes break output on mac os x. |
This was an old issue: |
@ChrisJefferson #915 was quite different, and was fixed since. Do you mean that the issue still applies ? |
#915 still isn't fixed ( |
So as mentioned in #1291 seems like this issue is still coming back every now an then. |
What is the benefit of unicode quotes? (My vote is for ASCII quotes.) |
Current discussion: NixOS/rfcs#4 |
Removed unicode quotes everywhere except in the documentation.
Tests still pass \o/.
The documentation may contain inappropriate unicode quotes if it reproduces output from a nix command.
I quickly went through the doc, and found no such case.