Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of unicode quotes #1140

Merged
merged 1 commit into from Nov 25, 2016
Merged

Conversation

layus
Copy link
Member

@layus layus commented Nov 25, 2016

Removed unicode quotes everywhere except in the documentation.
Tests still pass \o/.

The documentation may contain inappropriate unicode quotes if it reproduces output from a nix command.
I quickly went through the doc, and found no such case.

@domenkozar
Copy link
Member

I'll merge this quickly before it gets out of sync. Other PRs will get out of sync, but we can't really avoid that.

@domenkozar domenkozar merged commit f78126b into NixOS:master Nov 25, 2016
edolstra added a commit that referenced this pull request Nov 25, 2016
This reverts commit f78126b. There
really is no need for such a massive change...
@vcunat
Copy link
Member

vcunat commented Nov 26, 2016

Info/ping: reverted. (I personally don't have a strong opinion on this.)

@layus
Copy link
Member Author

layus commented Nov 28, 2016

@vcunat I don't care either, but we need global guidelines. In #947, @domenkozar asked me to use ASCII quotes, which also made sense. This PR is just the generalization of the aforementioned comment. Do we want to

  1. Keep unicode quotes
  2. Use only ASCII quotes
  3. Transition slowly (by changing only in modified files for example ?)

@edolstra: Does your commit message (hereafter) mean that there is need for any change ?

Revert "Get rid of unicode quotes (#1140)"

This reverts commit f78126b. There
really is no need for such a massive change...

@cstrahan
Copy link
Contributor

Ah, bummer. I don't even know how I'd enter a non-ASCII quote, aside from copy paste... So it would seem like a nice thing to get rid of them. (They don't look/feel significantly better, and they tend to trip up text selections in terminal emulators.)

@copumpkin
Copy link
Member

@edolstra any comment?

@domenkozar
Copy link
Member

domenkozar commented Dec 6, 2016

(3) is really really painful, as each contirbutor has to change something she/he wasn't responsible for. That's why I went for 2.

@ChrisJefferson
Copy link

These unicode quotes break output on mac os x.

@ChrisJefferson
Copy link

This was an old issue:

#915

@layus
Copy link
Member Author

layus commented Feb 14, 2017

@ChrisJefferson #915 was quite different, and was fixed since. Do you mean that the issue still applies ?

@ChrisJefferson
Copy link

#915 still isn't fixed (curl https://nixos.org/nix/install | sh still doesn't work). Part of the problem there was (I thought) the use of unicode quotes confusing the shell.

@unode
Copy link
Member

unode commented Mar 26, 2017

So as mentioned in #1291 seems like this issue is still coming back every now an then.
Does the benefit of unicode quotes justify the hassle?

@bjornfor
Copy link
Contributor

What is the benefit of unicode quotes? (My vote is for ASCII quotes.)

@vcunat
Copy link
Member

vcunat commented Mar 26, 2017

Current discussion: NixOS/rfcs#4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants