sks: init at 1.1.6 #20717
sks: init at 1.1.6 #20717
Conversation
| postInstall = '' | ||
| mkdir --parents $out/var/lib/sks | ||
| rm --recursive ./sampleConfig/debian | ||
| cp ./sampleConfig/* $out/var/lib/sks |
There was a problem hiding this comment.
This is not a good patch for sample configs. In var should be variable data like state. This shouldn't typically be in the Nix store.
We don't have a clear convention where to put sample configs but most packages use paths like $out/etc, $out/share or $out/share/doc (last one being from the Debian Policy).
| rm --recursive ./sampleConfig/debian | ||
| cp ./sampleConfig/* $out/var/lib/sks | ||
| mkdir $out/var/lib/sks/web | ||
| cp --recursive ./sampleWeb/* $out/var/lib/sks/web |
There was a problem hiding this comment.
Is sks looking for those files in that path? If not, $out/share would be a better place to put these files.
|
@rasendubi @fpletz Thanks for your Feedback! 😄 @fpletz Considering you feedback I concluded copying these sample configuration files was probably a bad idea to begin with as they're not really helping anyone by just being in the store path and if I should need some of them for the module I could re-add them anyway (keeping |
|
Oh, and are you also working on a NixOS module for sks by any chance? ;) |
|
@fpletz Yes, I'm trying to write a NixOS module for sks but it might take some time since I don't have that much time at the moment and I've only written one module so far that was way simpler. But hopefully it won't take me too long 😄 |
|
I have a local sks NixOS module (running http://ice.mudshark.org:11371). There are 3 main issues:
I only really solved the running of |
|
@jcumming Sounds awesome! Are you considering finalizing that module (doesn't have to be perfect -imho a minimal version would be enough to begin with) and making a PR? And if not would you mind sharing your work with me (dev.primeos@gmail.com)? |
Motivation for this change
Add SKS:
"SKS is an OpenPGP keyserver whose goal is to provide easy to deploy,
decentralized, and highly reliable synchronization. That means that a key
submitted to one SKS server will quickly be distributed to all key
servers, and even wildly out-of-date servers, or servers that experience
spotty connectivity, can fully synchronize with rest of the system."
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/) (I couldn't test all binaries yet but the unit tests and "sks version" succeed. I.e. everything should be fine.)I've copied the sample configuration files to
$out/var/lib/sksas I thought about writing a module that just copies some of these config files (especially the web files) to/var/lib/sks- might be a bad idea tho... They might also be useful as a reference but I guess one normally wouldn't look for them under the store path.