pythonPackages.magic-wormhole: enable tests #20722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@asymmetric @garbas now I am getting really confused here. Is this an application or a library? |
|
@FRidh as said also by @asymmetric should i move |
FRidh
added a commit
that referenced
this pull request
May 3, 2017
- fixes build - use buildPythonPackage and pass in individual packages As mentioned in #20722 this packages is both an application and a library. If a package is both then we use buildPythonPackage and put it in python-packages.nix. That way we can guarantee we use the correct version of dependencies when using it as a library. Unfortunately, it does mean the name of the package is prefixed with `pythonX.X-`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)