ghcWithPackages: fix env NIX_GHC_LIBDIR value #20731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ideally the duplication between the environment shellHook and the ghc wrapper would be removed. Fixes NixOS#20730
|
@expipiplus1, thanks for your PR! By analyzing the history of the files in this pull request, we identified @cstrahan, @peti and @shlevy to be potential reviewers. |
|
Apparently the variable was broken by @Profpatsch's change 499e4e6. Hmm. Let me think about this for a moment. |
|
Looks like this is the way to go. Since these paths are constructed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes #20730
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)Ideally the duplication between the environment shellHook and the ghc
wrapper would be removed.